Fix mpi.conf templating #203
Conversation
Summary of ChangesHello @bertiethorpe, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request implements a minor but crucial syntax correction within the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly fixes a syntax error in the mpi.conf.j2 Jinja2 template. The change adds the required parentheses to the .items() method call, which is necessary to iterate over the openhpc_mpi_config dictionary. While the fix itself is correct, I've noticed that the current test suite does not seem to cover this templating logic, as openhpc_mpi_config is empty by default. To improve robustness and prevent future regressions, I recommend extending the molecule tests to include a scenario where openhpc_mpi_config is populated and then verify the contents of the generated mpi.conf file.
Bug slipped through CI because mpi.conf not populated in .stackhpc environment.
Fixed by correcting parentheses on the .items() method in mpi.conf.j2 template. dict.items without parentheses refers to the method itself, not the result of calling it, so Ansible is trying to iterate over a function object